fix: improve error hints when select * from xx.yy (databendlabs#14663)

* fix: improve error hints when select * from xx.yy * fix: improve error hints when select * from xx.yy * feat: add test * feat: add test * Update tests/sqllogictests/suites/base/issues/issue_13718.test Co-authored-by: Bohu <[email protected]> * fix issue_13718.test --------- Co-authored-by: Bohu <[email protected]>
ZhiHanZ · Mar 24, 2024 · 3a50f2c · 3a50f2c
1 parent c3b148d
commit 3a50f2c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/query/sql/src/planner/binder/table.rs b/src/query/sql/src/planner/binder/table.rs
@@ -250,6 +250,13 @@ impl Binder {
                     }
                     parent = bind_context.parent.as_mut();
                 }
+                if e.code() == ErrorCode::UNKNOWN_DATABASE {
+                    return Err(ErrorCode::UnknownDatabase(format!(
+                        "Unknown database `{}` in catalog '{catalog}'",
+                        database
+                    ))
+                    .set_span(*span));
+                }
                 if e.code() == ErrorCode::UNKNOWN_TABLE {
                     return Err(ErrorCode::UnknownTable(format!(
                         "Unknown table `{database}`.`{table_name}` in catalog '{catalog}'"

diff --git a/tests/sqllogictests/suites/base/issues/issue_13718.test b/tests/sqllogictests/suites/base/issues/issue_13718.test
@@ -0,0 +1,5 @@
+statement ok
+DROP DATABASE IF EXISTS xx
+
+statement error (?s)1003.*Unknown database `xx` in catalog 'default'
+select * from xx.yy;