Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix pull detection by yell ignoring noMultiBoss #201

Merged
merged 3 commits into from
Jul 20, 2024

Conversation

oomshroom
Copy link
Contributor

Fix logic error causing noMultiBoss set by DisableMultiBossPulls() to be ignored

Fix logic error causing noMultiBoss set by DisableMultiBossPulls() to be ignored
@Zidras Zidras self-requested a review June 10, 2024 11:39
@Zidras Zidras self-assigned this Jun 10, 2024
@Zidras
Copy link
Owner

Zidras commented Jun 26, 2024

@oomshroom , your fix is indeed valid as it uncovers a faulty logic. However, this brings another problem to solve which is encounters that do have multiboss (OS 3 drakes comes to mind, even though it currently has code to purposefully disable multiboss).
Might I ask which case(s) led you to uncover this bug?

@oomshroom
Copy link
Contributor Author

@oomshroom , your fix is indeed valid as it uncovers a faulty logic. However, this brings another problem to solve which is encounters that do have multiboss (OS 3 drakes comes to mind, even though it currently has code to purposefully disable multiboss). Might I ask which case(s) led you to uncover this bug?

In OS 3-drake it was causing the mods for each drake to start up, in addition to the Sartharion mod, resulting in duplicate warnings for Void Blast.

However, full disclosure, this happened on a different server which I am adapting this DBM for. I do not know if this bug does or does not manifest itself in any way on Warmane, so it would be understandable for this issue to not be a priority for you.

@Zidras Zidras force-pushed the main branch 2 times, most recently from 333b7ca to 0ccb47a Compare July 5, 2024 20:43
@Zidras
Copy link
Owner

Zidras commented Jul 20, 2024

@oomshroom , your fix is indeed valid as it uncovers a faulty logic. However, this brings another problem to solve which is encounters that do have multiboss (OS 3 drakes comes to mind, even though it currently has code to purposefully disable multiboss). Might I ask which case(s) led you to uncover this bug?

In OS 3-drake it was causing the mods for each drake to start up, in addition to the Sartharion mod, resulting in duplicate warnings for Void Blast.

However, full disclosure, this happened on a different server which I am adapting this DBM for. I do not know if this bug does or does not manifest itself in any way on Warmane, so it would be understandable for this issue to not be a priority for you.

If core logic is wrong, then it must be addressed. My question was meant to ascertain different scenarios that I may not be seeing, that would require fixing on a mod level, hence my request for you to disclose which boss(es) led you to the troubleshooting

@Zidras Zidras merged commit feb08b8 into Zidras:main Jul 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants