Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bluebell parser instead of parsing scilla-fmt s-exp #3

Merged
merged 27 commits into from
Jan 8, 2024
Merged

Use bluebell parser instead of parsing scilla-fmt s-exp #3

merged 27 commits into from
Jan 8, 2024

Conversation

its-saeed
Copy link
Contributor

This PR tries to use bluebell parser instead of parsing the s-exp. Thanks to @troelsfr

saeed-zil and others added 27 commits January 3, 2024 17:16
@saeed-zil
Use bluebell parser instead of parsing scilla-fmt s-exp
5af0de7
@saeed-zil
Merge branch 'main' of https://github.com/Zilliqa/rs-scilla-parser in…
1206ce3 
…to use-bluebell-parser
@saeed-zil
Start implementing the AstConverting for Contract.
844398a
@saeed-zil
Pass the first test.
a3b3c44
@saeed-zil
Pass the next test
2f44473
@saeed-zil
Pass next test.
6d9108c
@saeed-zil
Simplify intermediate representation.
6ebc8c2
@saeed-zil
Rename
2727679
@saeed-zil
Support complex types
f579ca0
@saeed-zil
ByStr buggy contract.
17efa31
@troelsfr
Updating grammar
91302f0
@saeed-zil
One more passing test ^_^
157800b
@saeed-zil
Pass one more test!
a0464bc
@saeed-zil
Remove dependency to lexpr
3dc64c1
@saeed-zil
Support map
e15ce6f
@saeed-zil
Support complex map types
25466c9
@saeed-zil
Pass one more test.
c1ea3d1
@saeed-zil
All tests passed.
f5a8fb0
@saeed-zil
All tests passed
ef57b0d
@saeed-zil
Remove commented codes
2d5e2d5
@saeed-zil
Remove useless code
9cf21cd
@saeed-zil
Refactor, remove useless code
1022a77
@saeed-zil
Fix doc tests
7b8f42b
@saeed-zil
Remove namespaces.
767f39a
@saeed-zil
Remove useless code.
428484f
@saeed-zil
Update readme
8fd9ef3
@saeed-zil
Remove panic
e398dc6
troelsfr
troelsfr reviewed Jan 8, 2024
View reviewed changes
src/type.rs Show resolved Hide resolved
troelsfr
troelsfr approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@troelsfr troelsfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor optional comment, and then we probably ought to open a ticket in JIRA to finish the implementation (unless you are planning on implementing the remaining unimplemented! right away)

@its-saeed its-saeed merged commit 538a3f5 into main Jan 8, 2024
@its-saeed its-saeed deleted the use-bluebell-parser branch January 8, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troelsfr troelsfr troelsfr approved these changes

@rrw-zilliqa rrw-zilliqa Awaiting requested review from rrw-zilliqa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@its-saeed @troelsfr @saeed-zil