Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcpkg installation script requires Linux 64-bit #1203

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jjcnn
Copy link
Contributor

@jjcnn jjcnn commented Nov 22, 2022

The installation instructions and the vcpkg.sh script assumes the user is on a Linux 64-bit architecture. This PR changes the script to make an explicit check to ensure the assumption is satisfied.

Further, INSTALL.md has been updated to reflect the changes.

@ilyasergey : I think you're the only one in the Scilla team who has access to a Mac. Could you check that this works/doesn't work as expected?

@jjcnn jjcnn requested a review from ilyasergey November 22, 2022 15:49
@anton-trunov
Copy link
Contributor

Hey @jjcnn, I cannot clone the repo anymore:

❯ git clone --jobs 4 --recurse-submodules https://github.com/Zilliqa/scilla
Cloning into 'scilla'...
remote: Enumerating objects: 30519, done.
remote: Counting objects: 100% (907/907), done.
remote: Compressing objects: 100% (554/554), done.
remote: Total 30519 (delta 494), reused 677 (delta 345), pack-reused 29612
Receiving objects: 100% (30519/30519), 12.10 MiB | 463.00 KiB/s, done.
Resolving deltas: 100% (23660/23660), done.
Submodule 'deps/cryptoutils/src' (https://github.com/Zilliqa/cryptoutils) registered for path 'deps/cryptoutils/src'
Submodule 'deps/schnorr/src' (https://github.com/Zilliqa/schnorr) registered for path 'deps/schnorr/src'
Cloning into '/Users/anton/zilliqa/scilla/deps/cryptoutils/src'...
remote: Enumerating objects: 147, done.
remote: Counting objects: 100% (147/147), done.
remote: Compressing objects: 100% (105/105), done.
remote: Total 147 (delta 51), reused 116 (delta 29), pack-reused 0
Receiving objects: 100% (147/147), 79.73 KiB | 208.00 KiB/s, done.
Resolving deltas: 100% (51/51), done.
Cloning into '/Users/anton/zilliqa/scilla/deps/schnorr/src'...
remote: Enumerating objects: 341, done.
remote: Counting objects: 100% (82/82), done.
remote: Compressing objects: 100% (30/30), done.
remote: Total 341 (delta 56), reused 54 (delta 52), pack-reused 259
Receiving objects: 100% (341/341), 106.51 KiB | 200.00 KiB/s, done.
Resolving deltas: 100% (193/193), done.
fatal: remote error: upload-pack: not our ref 13a9728da8469420fac9cc1638c5001ee7d58827
fatal: Fetched in submodule path 'deps/cryptoutils/src', but it did not contain 13a9728da8469420fac9cc1638c5001ee7d58827. Direct fetching of that commit failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants