Add 'blessed' transactions which are exempt from gas price rules #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHinshelwood
requested review from
bzawisto,
DrZoltanFazekas,
rrw-zilliqa and
theo-zil
JamesHinshelwood
force-pushed
the
blessed-txs
branch
from
63903e8 to
a9b43a5
Compare
JamesHinshelwood
force-pushed
the
blessed-txs
branch
3 times, most recently
from
2b9492b to
174b41b
Compare
rrw-zilliqa
previously approved these changes
Jun 21, 2024
…ministic deployment proxy. This PR also enables the REVM balance check. Previously, this was disabled because Scilla transfers would use the EVM execution flow and they often contained overly high gas limits. This is no longer the case. More alarmingly, it turns out that when the check is disabled, REVM just gives the sender of a transaction enough money to cover that transaction, meaning funds are invented out of thin air. So now mean that the sender of a transaction needs to have enough money to cover the provided `gas_limit * gas_price + amount`. This means we've had to change how our 'system' transactions are processed. Previously, they would set a very high gas_limit and gas_price and the signer was the zero address. This obviously doesn't work any more since the zero address doesn't have any money at genesis. Instead, we now set the gas_price to zero and disable the gas price checks. Resolves #1059
JamesHinshelwood
force-pushed
the
blessed-txs
branch
from
174b41b to
eafef24
Compare
rrw-zilliqa
approved these changes
Jun 24, 2024
|
#1081 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this just includes the deployment transaction for the deterministic deployment proxy.
This PR also enables the REVM balance check. Previously, this was disabled because Scilla transfers would use the EVM execution flow and they often contained overly high gas limits. This is no longer the case. More alarmingly, it turns out that when the check is disabled, REVM just gives the sender of a transaction enough money to cover that transaction, meaning funds are invented out of thin air. So now mean that the sender of a transaction needs to have enough money to cover the provided
gas_limit * gas_price + amount.This means we've had to change how our 'system' transactions are processed. Previously, they would set a very high gas_limit and gas_price and the signer was the zero address. This obviously doesn't work any more since the zero address doesn't have any money at genesis. Instead, we now set the gas_price to zero and disable the gas price checks.
Resolves #1059