Improvements in deposit.sol
#1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHinshelwood
previously approved these changes
Nov 13, 2024
DrZoltanFazekas
force-pushed
the
deposit-contract-improvements
branch
from
6a59ad6 to
c47b42a
Compare
JamesHinshelwood
previously approved these changes
Nov 14, 2024
JamesHinshelwood
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR shall implement two urgent improvements:
getFutureStake()function to retrieve the staker's latest balance even if not yet effective i.e. future balance (required for the correct price calculation in liquid staking)nodes.consensus.unbonding_periodconfigured in the toml file (to enable shorter testing cycles of stake withdrawals on the devnet)