Use redb instead of SQLite #1915
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHinshelwood
force-pushed
the
redb
branch
from
0328f8c to
6f6bdfb
Compare
|
Can we run it for a week and measure the block-slowdown timings (if any)? |
JamesHinshelwood
force-pushed
the
redb
branch
3 times, most recently
from
fa0e0b6 to
7c83587
Compare
JamesHinshelwood
force-pushed
the
redb
branch
2 times, most recently
from
f36a60e to
a5f4f48
Compare
|
Bencher Report| Branch | redb |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 9,061,300.00 (-0.94%) | 10,577,299.32 (85.67%) |
| produce-full/produce-full | 📈 view plot 🚷 view threshold | 1,310,700,000.00 (-28.67%) | 2,508,211,219.86 (52.26%) |
JamesHinshelwood
force-pushed
the
redb
branch
7 times, most recently
from
ddd26b6 to
cf0e111
Compare
JamesHinshelwood
force-pushed
the
redb
branch
5 times, most recently
from
16634a8 to
20015e0
Compare
JamesHinshelwood
force-pushed
the
redb
branch
from
20015e0 to
c25d061
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance of redb in devnet compared to SQLite is much faster. I don't necessarily blame SQLite for this, since it could easily be our transaction management, SQL queries, lack of indices, etc. that are making the existing implementation slow. However, I do feel confident saying that this interface makes it clearer what work the database is doing and makes it harder to accidentally do slow things.