Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deposit_v3 use block number for withdrawal unbonding period #2007

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

86667
Copy link
Contributor

@86667 86667 commented Dec 12, 2024

Waiting for merge of #1879.

These changes have been tested via delegate_staking tests on branch deposit_v3_changes. I'll keep them on this branch until we deploy deposit_v3 in the coming weeks.

@86667 86667 self-assigned this Dec 12, 2024
@86667 86667 linked an issue Dec 12, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Dec 12, 2024

🐰 Bencher Report

Branch1761-fix-unbonding-period-in-depositsol
Testbedself-hosted
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
process-empty/process-empty📈 view plot
🚷 view threshold
9,348,700.00
(+0.86%)
10,660,391.25
(87.70%)
produce-full/produce-full📈 view plot
🚷 view threshold
1,967,200,000.00
(-16.40%)
3,170,173,653.69
(62.05%)
🐰 View full continuous benchmarking report in Bencher

@86667 86667 changed the title feat: deposit_v3 use block number for withdrawal unbonding period feat: deposit_v3 use block number for withdrawal unbonding period and add signingAddress Dec 12, 2024
@86667 86667 changed the title feat: deposit_v3 use block number for withdrawal unbonding period and add signingAddress feat: deposit_v3 use block number for withdrawal unbonding period Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix unbonding period in deposit.sol
1 participant