Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deposit_v3 multiple fixes #2008

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

86667
Copy link
Contributor

@86667 86667 commented Dec 12, 2024

These changes have been tested via delegate_staking tests on branch deposit_v3_changes. I'll keep them on this branch until we deploy deposit_v3 in the coming weeks.

@86667 86667 linked an issue Dec 12, 2024 that may be closed by this pull request
@86667 86667 self-assigned this Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

🐰 Bencher Report

Branch1876-add-signingaddress-to-deposit-in-depositsol
Testbedself-hosted
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
process-empty/process-empty📈 view plot
🚷 view threshold
9,357,500.00
(+1.45%)
10,579,137.38
(88.45%)
produce-full/produce-full📈 view plot
🚷 view threshold
1,959,100,000.00
(-12.22%)
3,095,137,186.97
(63.30%)
🐰 View full continuous benchmarking report in Bencher

@86667 86667 changed the title feat: deposit_v3 signingAddress specified in deposit() feat: deposit_v3 multiple fixes Dec 13, 2024
@86667 86667 changed the base branch from main to 1297-improve-validator-address-verification-in-deposit-contract December 13, 2024 10:03
@86667 86667 changed the base branch from 1297-improve-validator-address-verification-in-deposit-contract to main December 13, 2024 10:03
@86667 86667 force-pushed the 1876-add-signingaddress-to-deposit-in-depositsol branch from 1baed43 to 15ca457 Compare December 16, 2024 10:19
@86667 86667 marked this pull request as ready for review December 16, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add signingAddress to deposit() in deposit.sol
1 participant