Ensure state is correct in both EVM and Scilla environments #2414
+385
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bencher Report| Branch | fix-interop |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result milliseconds (ms) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| full-blocks-erc20-transfers/full-blocks-erc20-transfers | 📈 view plot 🚷 view threshold | 966.32 ms(-13.04%)Baseline: 1,111.17 ms | 1,467.93 ms (65.83%) |
| full-blocks-evm-transfers/full-blocks-evm-transfers | 📈 view plot 🚷 view threshold | 372.68 ms(-9.12%)Baseline: 410.09 ms | 490.90 ms (75.92%) |
| full-blocks-zil-transfers/full-blocks-zil-transfers | 📈 view plot 🚷 view threshold | 4,046.90 ms(+2.27%)Baseline: 3,956.96 ms | 5,426.57 ms (74.58%) |
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 9.68 ms(-3.29%)Baseline: 10.01 ms | 10.69 ms (90.55%) |
JamesHinshelwood
force-pushed
the
fix-interop
branch
2 times, most recently
from
fcea5fd to
09ca46a
Compare
When an interop. transaction is run, we need to be careful to keep track of state changes in both sides of the world. This PR takes the approach of: * Let `revm` keep track of EVM state changes as normal. * When an interop call is made to the Scilla interpreter, we make sure any 'pending' changes from the EVM side are visible to the Scilla contract. * When the Scilla call finishes, if any 'pending' EVM changes were modified further, we apply those changes to the EVM state journal before transferring control back to `revm`. This ensures the state we read is consistent and that when we come to apply state delta updates, there is no overlap between the EVM and Scilla state maps.
JamesHinshelwood
force-pushed
the
fix-interop
branch
from
09ca46a to
dcaf9c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an interop. transaction is run, we need to be careful to keep track of state changes in both sides of the world.
This PR takes the approach of:
revmkeep track of EVM state changes as normal.revm.This ensures the state we read is consistent and that when we come to apply state delta updates, there is no overlap between the EVM and Scilla state maps.