-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZCS-11191: [Backend] Integrate postsrsd #1274
base: develop
Are you sure you want to change the base?
Conversation
(cherry picked from commit d7f4e71)
d7f4e71
to
bb62b0b
Compare
|
@@ -1527,7 +1527,9 @@ public enum PUBLIC_SHARE_VISIBILITY { samePrimaryDomain, all, none }; | |||
public static final KnownKey zimbra_strict_unclosed_comment_tag = KnownKey.newKey(true); | |||
public static final KnownKey zimbra_skip_tags_with_unclosed_cdata = KnownKey.newKey("style"); | |||
|
|||
|
|||
//ZCS-11191 : Allow to enable/disable SRS feature | |||
public static final KnownKey zimbra_srs_enabled = KnownKey.newKey(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to put this into LC instead of LDAP? are we planning to release this feature in a patch?
@@ -58,6 +67,8 @@ public Element handle(Element request, Map<String, Object> context) throws Servi | |||
} | |||
checkRight(zsc, context, server, attrs); | |||
|
|||
startOrStopPostSRSd(server, attrs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this going to be called with every modifyServer call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@silentsakky, I think the same this code should not be here, as zmcontrol and all other service's stop/start functionality is written in zm-core-utils repo, which is in Perl script. This logic should also be written in that repo, also would like to confirm the same with @desouzas .
@desouzas : Could you please provide your inputs here? Thanks..!!
Problem
This PR has the solution for ZCS-11191, which is about to implement a mechanism to enable/disable the PostSRSd service in Zimbra.
Solution
Notes
Testing Done
This solution can be tested following the next steps: