ZCS-12002:failed test case of testBug64974 #1393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupeshtelus
requested review from
abhishekdeshmukh2209,
dasiyogesh,
dawoodshaikh,
gabhinavTI,
inpati,
k-kato,
shrutig0510,
silentsakky and
zimsuchitgupta
rupeshtelus
force-pushed
the
feature/ZCS-12002
branch
from
108b73a to
5b9a21a
Compare
dasiyogesh
reviewed
Aug 30, 2022
| formattedHtml = formattedHtml + strAfterSplit; | ||
| } | ||
| //ZCS-12002 ( failed test case for testBug64974 ) | ||
| //if the html doesn't containing start then skipping other operations |
jeastman
reviewed
Sep 26, 2022
| //if the html doesn't containing start then skipping other operations | ||
| if (arrOfStr.length > 1) { | ||
| for (String strAfterSplit : arrOfStr) { | ||
| if (!strAfterSplit.equals("") && strAfterSplit.contains(end)) { |
There was a problem hiding this comment.
For safety reasons (and avoiding a NullPoitnerException), you should compare the literal string to the variable.
!strAfterSpit.equals("")
should be:
!"".equals(strAfterSpit)
|
The original fix of ZBUG-2547 has been reworked in f82c5af |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket - https://jira.corp.synacor.com/browse/ZCS-12002
issue - failed test case of testBug64974
solution - if the html doesn't contain any start tag ( exp - '<!--' ) then it doesn't need to do operations of splitting & replacing tags , so added if conditions above it , if the length will be > 1 then only it will do all operations