-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZCS-13176 : Add mail recall message verification header #1468
Open
shubhamCS03
wants to merge
1
commit into
feature/mailRecall_ZCS-12409
Choose a base branch
from
ZCS-13176
base: feature/mailRecall_ZCS-12409
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamCS03
force-pushed
the
ZCS-13176
branch
3 times, most recently
from
March 23, 2023 11:34
d156509
to
01c1c45
Compare
swaatiTelus
reviewed
Mar 23, 2023
swaatiTelus
changed the title
Zcs 13176
ZCS-13176 : Add mail recall message verification header
Mar 23, 2023
shubhamCS03
requested review from
dasiyogesh,
gautamdg,
dawoodshaikh,
desouzas,
k-kato,
ronstra-synacor,
shrutig0510,
vishnukantjangid,
RakeshAMore,
zimsuchitgupta,
barrydegraaff and
swaatiTelus
March 23, 2023 13:44
ronstra-synacor
suggested changes
Mar 23, 2023
ronstra-synacor
suggested changes
Mar 23, 2023
k-kato
reviewed
Mar 24, 2023
ronstra-synacor
previously approved these changes
Mar 24, 2023
shrutig0510
reviewed
Dec 27, 2024
|
||
package com.zimbra.soap.mail.message; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
shubhamCS03
changed the base branch from
ZCS-12409
to
feature/mailRecall_ZCS-12409
January 2, 2025 11:34
shrutig0510
approved these changes
Jan 2, 2025
soap/src/java/com/zimbra/soap/mail/message/MailRecallRequest.java
Outdated
Show resolved
Hide resolved
store/src/java/com/zimbra/cs/account/callback/GenerateSecretKeyCallback.java
Outdated
Show resolved
Hide resolved
store/src/java/com/zimbra/cs/account/callback/GenerateSecretKeyCallback.java
Show resolved
Hide resolved
store/src/java/com/zimbra/cs/account/callback/GenerateSecretKeyCallback.java
Show resolved
Hide resolved
store/src/java/com/zimbra/cs/service/admin/GenerateSecretKey.java
Outdated
Show resolved
Hide resolved
shubhamCS03
requested review from
mamtadahiwal,
shrutig0510 and
chitranshu198
January 15, 2025 08:50
mamtadahiwal
approved these changes
Jan 15, 2025
chitranshu198
approved these changes
Jan 15, 2025
shrutig0510
approved these changes
Jan 15, 2025
shubhamCS03
force-pushed
the
ZCS-13176
branch
from
January 15, 2025 17:32
a38142d
to
7525ae9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement of ticket [ZCS-13176]
Requirements:
Solution:
hash=[string] --the algorithm used to produce the hash value in the "guid" tag. Current valid values are "SHA1" and "SHA256" [[SHA]].
guid=[base64] --the base64 encoding [[Base64]] of the hash of a globally unique ID (GUID) for the message, using the hash algorithm specified in the "hash" tag. The actual GUID (the pre-image of the hash) is kept secret by the sending side.
Testing: