Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker all the things! #2

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

Docker all the things! #2

wants to merge 29 commits into from

Conversation

xerootg
Copy link
Contributor

@xerootg xerootg commented Jan 10, 2023

I still need to hook up all the networking, but docker compose build (implementing your constants, obviously) builds, and docker compose up starts all the services.

@xerootg xerootg marked this pull request as draft January 10, 2023 05:04
@@ -11,7 +11,7 @@
*/
"AzureAd": {
"Instance": "https://login.microsoftonline.com/",
"Domain": "commerce.zunes.me",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I missed one.

Member member = ctx.Members.First(m => m.ZuneTag == zuneTag);
if (member == null)
return StatusCode(StatusCodes.Status400BadRequest, $"User {zuneTag} does not exist.");
// using var ctx = new ZuneNetContext();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not compile right now. Do you have a branch where it does, that I should rebase against?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I just haven't touched messaging in a long time. Don't worry about it

@@ -15,7 +15,7 @@ class Program
static async Task Main(string[] args)
{
// Set up CLI options
string connectionString = "mongodb://localhost:27017";
string connectionString = "mongodb://mongo:27017";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be pulled into IConfiguration so that it can be one of many configuration types including environment variables.

@@ -1,6 +1,6 @@
{
"ZuneNetContext": {
"ConnectionString": "mongodb://localhost:27017",
"ConnectionString": "mongodb://mongo:27017",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In docker, you can expose things like connection strings to a running container as an environment variables. I'm gonna probably revert this to localhost and define the runtime connection strings in docker-compose.yml

WORKDIR /source

# copy csproj and restore as distinct layers
COPY ./ .
Copy link
Contributor Author

@xerootg xerootg Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this should be broken into layers of dependency. I need to research the right way to do this for a .net project like this.

version: '3.4'

services:
mongodb:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to see if this can start and finish booting before the rest of the containers start

…to recover your own SID from the POST and add it to your profile to use it though.
also Parallel.ForEachAsync is cool.
also albumart sort of loads
…same resizing routines for the v3.2 endpoints
…en the tracking gif is missing by adding one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants