analysis:fix - Fix analysis not update otherss fields if alredy exists (

#525) When Horusec-API receive new analysis the fields column, confidence, security_tool, language aren't updated if vulnerabilityID already exists in database, then I updated the map of the entity for update this fields too. Signed-off-by: wilian <[email protected]>
ZupIT · Jan 13, 2022 · dd9e76e · dd9e76e
1 parent 9c1615c
commit dd9e76e
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/api/internal/repositories/analysis/analysis.go b/api/internal/repositories/analysis/analysis.go
@@ -110,12 +110,13 @@ func (a *Analysis) createVulnerabilityIfNotExists(vuln *vulnerability.Vulnerabil
 		if !exists {
 			return vuln.VulnerabilityID, tsx.Create(vuln, vuln.GetTable()).GetError()
 		}
-		return a.updateCommitAuthors(vuln, res.GetData(), tsx)
+		return a.updateVulnerability(vuln, res.GetData(), tsx)
 	}
 	return uuid.Nil, err
 }
 
-func (a *Analysis) updateCommitAuthors(vuln *vulnerability.Vulnerability, resFindVuln interface{},
+// nolint:funlen // method is not necessary broken
+func (a *Analysis) updateVulnerability(vuln *vulnerability.Vulnerability, resFindVuln interface{},
 	tsx database.IDatabaseWrite) (uuid.UUID, error) {
 	vulnID, err := uuid.Parse(resFindVuln.(map[string]interface{})["vulnerability_id"].(string))
 	if err != nil {
@@ -124,6 +125,10 @@ func (a *Analysis) updateCommitAuthors(vuln *vulnerability.Vulnerability, resFin
 	tableName := (&vulnerability.Vulnerability{}).GetTable()
 	condition := map[string]interface{}{"vulnerability_id": vulnID}
 	entity := map[string]interface{}{
+		"column":         vuln.Column,
+		"confidence":     vuln.Confidence.ToString(),
+		"security_tool":  vuln.SecurityTool.ToString(),
+		"language":       vuln.Language.ToString(),
 		"commit_author":  vuln.CommitAuthor,
 		"commit_email":   vuln.CommitEmail,
 		"commit_hash":    vuln.CommitHash,