Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 防止自动ban掉队友预选的英雄 #253

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Fix: 防止自动ban掉队友预选的英雄 #253

merged 4 commits into from
Feb 22, 2024

Conversation

Ninohana
Copy link
Contributor

No description provided.

@Zzaphkiel
Copy link
Owner

感谢 PR!

  1. 感觉通过设置选项 cfg.pretentBan,让用户选择是否忽略队友预选英雄比较好一些?(我已经把 GUI 实现了,您可以 pull 一下🥰)
  2. 如果选项开启,要 Ban 的英雄和队友预选英雄相同,直接空 Ban 而不是等待时间耗完更好一些?
  3. BUG:由于将自动亮起放在了 __onChampSelectChanged 函数下,亮起英雄之后如果玩家想要选择其他英雄,在亮起其他英雄后也会进入到该函数中,重新亮起设置中预选的英雄,导致玩家无法选择其他的英雄
    希望可以在自动亮起时,通过判断玩家当前亮起的英雄(如果是刚进去选人的话应该是空,而玩家主动选择时会改变亮起英雄为其他英雄(没有实际测试,只是猜测)),来决定是否要调用 selectChampion,以防止玩家无法选择其他英雄

Fix:
开启时无法选择其他英雄
@Ninohana
Copy link
Contributor Author

采纳上述建议,本来是认为这个功能都是绝活哥在用,不需要换英雄(被ban了也选不了)。关于Ban英雄功能是否可以设置多个ban位,届时查漏补缺。

@Ninohana
Copy link
Contributor Author

因为一直秒退要等半个小时才能排了😭

@Zzaphkiel
Copy link
Owner

因为一直秒退要等半个小时才能排了😭

辛苦了,感谢 😘😘!

@Zzaphkiel Zzaphkiel merged commit 5e9b713 into Zzaphkiel:main Feb 22, 2024
2 checks passed
@Hpero4
Copy link
Contributor

Hpero4 commented Feb 22, 2024

Hi @Ninohana ,

可以尝试一下使用自定义的“征召模式”进行测试, 希望对您有所帮助😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants