Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: 特定条件下, 战绩查询会干掉客户端 #450

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

Hpero4
Copy link
Contributor

@Hpero4 Hpero4 commented Aug 15, 2024

  1. FIX 连续在候选栏选中两次相同召唤师会起两个task同时加载导致客户端闪退
  2. FIX 使用cancel()有时候无法终止task
  3. 优化战绩搜索UI响应速度

@Hpero4
Copy link
Contributor Author

Hpero4 commented Aug 17, 2024

修复 #451

@Hpero4
Copy link
Contributor Author

Hpero4 commented Aug 19, 2024

deb5fca 中引入了一个新的bug, 该bug导致相同用户进行查询时数据不会更新;
#449 (comment)

在最初的设计中, 考虑到cancel()有可能无法终止task导致同时存在2个task进行数据获取; 因此添加了puuid的二次审查, 当puuid相同时不再起task进行数据拉取;

puuid = summoner['puuid']

由于后续修复了cancel()无法终止task的bug, 因此对searchAndShowFirstPage的互斥锁以及puuid的二次判断变得不再是必要的;

@asyncLockDecorator('loadFirstPageLock')

考虑到互斥锁可以保证用户狂点搜索时的逻辑一致性, 故将其保留;
puuid的二次判断则在 ab80fa7 被移除;

@Zzaphkiel
Copy link
Owner

感谢感谢,这块代码太烧脑了,我也写不明白(

@Zzaphkiel Zzaphkiel merged commit d7da2ca into Zzaphkiel:main Aug 19, 2024
2 checks passed
@BruceQiu1996
Copy link

@Hpero4 请问客户端是lol游戏客户但闪退吗?还是软件

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants