Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG修复 #76

Merged
merged 8 commits into from
Sep 24, 2023
Merged

BUG修复 #76

merged 8 commits into from
Sep 24, 2023

Conversation

Hpero4
Copy link
Contributor

@Hpero4 Hpero4 commented Sep 23, 2023

  1. 修复了服务器异常时, 各页面存在的问题 (查战绩接口不返回games字段, 抛出SummonerGamesNotFound时处理)
  2. 修复了战绩查询逻辑错误
  3. 修复了战绩查询历史记录下拉框在特定操作下出现卡死的BUG
  4. 修复了战绩查询历史只保存了10个字符的BUG(正确应为10次记录)

历史战绩查不到games字段的情况存在于服务器异常时, 今晚在1区测的时候偶然发现的, 换个区又能查到, 后面1区也好了:
1695487151567

@Hpero4
Copy link
Contributor Author

Hpero4 commented Sep 23, 2023

问题2导致了最新代码中的"战绩查询"功能出现死锁, 一直处在加载中等待返回,

版本发布前请务必合入该pr或回滚上次commit

_(:з」∠) _

@Hpero4
Copy link
Contributor Author

Hpero4 commented Sep 24, 2023

尝试修复 #69

@Zzaphkiel
Copy link
Owner

感谢 PR!

@Zzaphkiel Zzaphkiel merged commit aa31537 into Zzaphkiel:main Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants