Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changed color of the app in settings #59

Closed

Conversation

AminTaheri23
Copy link

Description

I changed the colors in the dark theme and light theme from purple to blue. I know this seems small change, but I really didn't like the color. And not that fluent with React Native, and I wanted to participate in this project even if it's a small change.

Fixes no issues.

Platform Affected

  • iOS
  • Android

Checklist

  • Necessary comments have been made.
  • I have tested this change on:
    • iOS Simulator/Device
    • Android Emulator/Device
  • Unit tests and integration tests pass locally.

@a-ghorbani
Copy link
Owner

great! could you please share a few screenshots to help me visualize the impact of the new changes?

@AminTaheri23
Copy link
Author

Of course! It's not much but it's honest work :))

Before After
model menu before model menu after
setting menu before setting menu after

@a-ghorbani a-ghorbani mentioned this pull request Oct 25, 2024
7 tasks
@MahmoudMabrok
Copy link
Contributor

is it ready for merge @a-ghorbani ?

@a-ghorbani
Copy link
Owner

@AminTaheri23, thanks for sharing the screenshots. Could you please do the same for the light mode? Including the chat page?

@a-ghorbani
Copy link
Owner

a-ghorbani commented Nov 3, 2024

I tested the new blue primary color, and I think it looks nice - specifically in the dark mode! but, I'm noticing that changing just the primary color may create some inconsistencies across the theme. I’m not a designer, but it might be worth considering updates to other related colors, such as primaryContainer, onPrimary, and any other shades or accents related?

For reference, this app uses React Native Paper, which uses Material Design 3 color system: https://callstack.github.io/react-native-paper/docs/guides/theming/#creating-dynamic-theme-colors

On that note, since we currently don’t have a Figma design, this could be a good opportunity to start one? What do you think about setting up an initial Figma file for this?

@a-ghorbani
Copy link
Owner

We have updated the theme and chosen blue as the secondary color.

@a-ghorbani a-ghorbani closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants