Skip to content

Commit

Permalink
docs: fix description of WatchResponse.canceled
Browse files Browse the repository at this point in the history
Signed-off-by: Myrat92 <[email protected]>
  • Loading branch information
zhanghangfeng authored and a-nych committed Oct 16, 2024
1 parent 2fe3c6e commit e096cc5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Documentation/dev-guide/apispec/swagger/rpc.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -2982,7 +2982,7 @@
},
"canceled": {
"type": "boolean",
"description": "canceled is set to true if the response is for a cancel watch request.\nNo further events will be sent to the canceled watcher."
"description": "canceled is set to true if the response is for a cancel watch request\nor if the start_revision has already been compacted.\nNo further events will be sent to the canceled watcher."
},
"compact_revision": {
"type": "string",
Expand Down
3 changes: 2 additions & 1 deletion api/etcdserverpb/rpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion api/etcdserverpb/rpc.proto
Original file line number Diff line number Diff line change
Expand Up @@ -836,7 +836,8 @@ message WatchResponse {
// All events sent to the created watcher will attach with the same watch_id.
bool created = 3;

// canceled is set to true if the response is for a cancel watch request.
// canceled is set to true if the response is for a cancel watch request
// or if the start_revision has already been compacted.
// No further events will be sent to the canceled watcher.
bool canceled = 4;

Expand Down

0 comments on commit e096cc5

Please sign in to comment.