update fork #3
Merged
update fork #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted imports (#2792) local_name has `name` and `span`. We can't directly compare ExportEntry's local_name and ImportEntry's local_name. because the span is never equal.
…2796) Remove `verbatim_module_syntax` option, Because Babel's [onlyRemoveTypeImports](https://babeljs.io/docs/babel-plugin-transform-typescript#onlyremovetypeimports) option same behavior with `verbatim_module_syntax` , You can see babel/babel#15493 (comment)
… ModuleRecord (#2793) Now the span is ExportAllDeclaration's span
… the output content should be empty (#2808) #2795 (comment)
* move `visit` and `visit_mut` modules to a super module called `visit` * add `walk_mut` module containing walk functions * update `enter_node` and `leave_node` events to not pass a reference in the `VisitMut` trait * add `AstType`, a non-referencing version of `AstKind` to use with `VisitMut` trait * update the `VisitMut` trait's usages.
This does not depend on node.js, and sets persist-credentials to false
… [profile.dev] (#2812)
This PR updates the babel submodule in the justfile to take advantage of [this PR](babel/babel#16381). Related to #2795 and #2797.
In my privius PR I changed this version in justfile It seems like the version used in CI is different from justfile.
When we change `clone-submodules/action.yml`, the snapshot will probably be updated as well, so I'd run ci to make sure the snapshot is correct.
Change the `profile.dev.debug` value from `limited` to `1` which is the same thing according to [this](https://doc.rust-lang.org/cargo/reference/profiles.html#debug). For some reason, the numeric value was failing when running the codspeed benchmark. ------ #### Edit: it was resulting in the following error: ``` failed to parse manifest at `/home/runner/work/oxc/oxc/Cargo.toml` ``` Related to #2812
[es2015 transform literals](https://babeljs.io/docs/babel-plugin-transform-literals) --------- Co-authored-by: Dunqing <[email protected]>
Rule Detail: [link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/no-untyped-mock-factory.ts) --------- Co-authored-by: wenzhe <[email protected]> Co-authored-by: Dunqing <[email protected]>
With this PR all transformers would get their `AstBuilder` and options via `TransformerCtx`.
`cargo-machete` has been replaced with `cargo-shear`, so the package metadata for `cargo-machete` is no longer required.
Rule Detail: [link](https://github.com/jest-community/eslint-plugin-jest/blob/main/src/rules/prefer-comparison-matcher.ts) --------- Co-authored-by: Dunqing <[email protected]>
Should be merged after #2829, Tried a few times to get it done with graphite stacking but found no success. I guess it either doesn't work with forks or It is just a skill issue since I'm not familiar with it. closes: #2829 closes: #2830 --------- Co-authored-by: Dmytro Maretskyi <[email protected]>
…2822) Before this PR for this given case: ```javascript const _unused = "It's a lie, They gonna use me:("; try { throw 0; } catch { console.log(_unused); } ``` We would've generated this: ```javascript const _unused = "It's a lie, They gonna use me:("; try { throw 0; } catch (_unused) { console.log(_unused); } ``` This is incorrect, This PR aims to use the `CreateVars` trait in order to ensure the variable uniqueness. Now it would output this: ```javascript const _unused = "It's a lie, They gonna use me:("; try { throw 0; } catch (_unused2) { console.log(_unused); } ```
…portDefaultDeclaration (#2837)
…ses (#2835) Related to: #2822 (comment) Although `babel` has a lot of test cases, we still need to add edge cases that `babel` doesn't have. This PR will allow us to add out test cases to `/root/oxc/tasks/transform_conformance/tests`. The directory structure is consistent with `babel` For example ```shell # cd /root/oxc/tasks/transform_conformance/tests - babel-transform-plugin–optional-catch-binding - test - fixtures - your tests # add test cases here ```
Users usually do not need to manually set the tsconfig path, as it is usually located in cwd/tsconfig.json.
We should use `requested_modules` instead of `loaded_modules` because `loaded_modules` only contains successfully resolved modules.
Grouping unmergeable imports to determine if they are duplicates
github-actions
bot
added
A-ast
A-transformer
A-linter
A-parser
A-codegen
A-semantic
A-minifier
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.