-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/extend input descriptor #113
Merged
n0900
merged 22 commits into
feature/openid-data-classes
from
feature/extendInputDescriptor
Aug 28, 2024
Merged
Feature/extend input descriptor #113
n0900
merged 22 commits into
feature/openid-data-classes
from
feature/extendInputDescriptor
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodh
requested changes
Aug 27, 2024
vck-aries/src/commonMain/kotlin/at/asitplus/wallet/lib/aries/PresentProofProtocol.kt
Show resolved
Hide resolved
vck-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidc/OidcSiopVerifier.kt
Show resolved
Hide resolved
vck-openid/src/commonTest/kotlin/at/asitplus/wallet/lib/oidc/OidcSiopWalletScopeSupportTest.kt
Show resolved
Hide resolved
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/data/dif/InputDescriptor.kt
Outdated
Show resolved
Hide resolved
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/data/dif/TransactionDataEntry.kt
Outdated
Show resolved
Hide resolved
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/data/dif/TransactionDataEntry.kt
Outdated
Show resolved
Hide resolved
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/data/dif/TransactionDataEntry.kt
Outdated
Show resolved
Hide resolved
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/data/dif/TransactionDataEntry.kt
Outdated
Show resolved
Hide resolved
nodh
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes requested, then we're good to go
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/data/rqes/DocumentDigestEntry.kt
Outdated
Show resolved
Hide resolved
vck/src/commonMain/kotlin/at/asitplus/wallet/lib/data/rqes/DocumentDigestEntry.kt
Outdated
Show resolved
Hide resolved
e03e086
to
de0735d
Compare
nodh
requested changes
Aug 28, 2024
nodh
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
transaction_data
anddocumentDigests
as described in "POTENTIAL consortium D3.1: UC Specification"