Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement get_filter_changes #221

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sk1122
Copy link

@sk1122 sk1122 commented Apr 7, 2023

Ref - #200

Implemented eth_getFilterChanges according to discussion

Do not merge this yet

  • eth_getFilterChanges works for eth_newFilter, eth_newBlockFilter which returns different types of data (Vec & H256)

@sk1122
Copy link
Author

sk1122 commented May 3, 2023

Hey @ncitron, sorry for not updating, I am facing an issue in rust, get_filter_changes returns Vec<R>, R is a generic type, it can either be Vec<Log> or Vec<H256>, tried converting the result of ethers function to any and then to an Enum of both the types, but receiving another error

type inside `async` block must be known in this context
cannot infer type for type parameter `R` declared on the associated function `get_filter_changes`

can you help in this?

@ncitron
Copy link
Collaborator

ncitron commented May 3, 2023

Can you push what you have and point me to where you are getting an error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants