Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return null from getBlockTransactionCount methods for unsynced block #441

Merged
merged 3 commits into from
Nov 22, 2024
Merged

fix: return null from getBlockTransactionCount methods for unsynced block #441

merged 3 commits into from
Nov 22, 2024

Conversation

eshaan7
Copy link
Contributor

@eshaan7 eshaan7 commented Nov 21, 2024

Closes: #234.

@eshaan7 eshaan7 changed the title fix: return null from block tx count methods for unsynced block fix: return null from getBlockTransactionCount methods for unsynced block Nov 21, 2024
@eshaan7 eshaan7 marked this pull request as ready for review November 22, 2024 11:40
ncitron
ncitron approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncitron ncitron merged commit fa22bfd into a16z:master Nov 22, 2024
3 of 5 checks passed
@eshaan7 eshaan7 deleted the fix/gh-234 branch November 22, 2024 13:51
@eshaan7 eshaan7 mentioned this pull request Nov 22, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncitron ncitron ncitron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Standardization of responses according to eth_rpc specs for eth_ methods related to byNumber and byHash
2 participants
@eshaan7 @ncitron