fix: get_filter_changes return type

[eshaan7]

Closes #447.

---

1. Transaction hashes:

2. Block hashes:

3. Logs:

[ncitron]

This is a good start, but we want to be verifying all data returned by the filter is valid. The current standard we hold ourselves to is that an RPC should be able to withhold parts of the data, but should not be able to insert additional incorrect data (we'd like to check for exhaustiveness at some point too but there are some unfortunate blockers there for a few of the rpc methods like log fetching).

It looks like we aren't checking validity for the non-log filter return types. We should be able to do this by checking if any returned block, blockhash, transaction, or transaction hash has actually been seen by Helios. All of the data to perform these checks should be accessible from the State type.

[eshaan7]

It looks like we aren't checking validity for the non-log filter return types. We should be able to do this by checking if any returned block, blockhash, transaction, or transaction hash has actually been seen by Helios

So the eth_newBlockFilter filter returns block hashes, while the eth_newPendingTransactionFilter filter returns transaction hashes. In both cases, the response is an array of hashes without any indication of whether they are block hashes or transaction hashes. This makes verification quite tricky because Helios cannot verify the new transaction hashes — these are just transactions in the mempool and have not yet been included in any block. For block hashes, I can check if they exist in the state, but if they don’t, I can’t simply error out because they might actually be transaction hashes, and there’s no way to distinguish between the two.

For now, have added comments in the code with these notes.

[ncitron]

Oh this is a good point.

How that I think about it we should probably be managing more of the filter logic ourselves rather than farming it out to the RPC.

We should keep track of what filters we have, and only use the RPC to manage log and pending transaction filters. For new block filters we don't really need to use the rpc at all. We can just keep track of those filters in Helios and implement the logic directly for returning all the heads that helios has seen.