Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Sync Committee Logic and Add Unsafe Signer Verification #532

Closed
wants to merge 4 commits into from

Conversation

kilavvy
Copy link

@kilavvy kilavvy commented Feb 26, 2025

Description:

This pull request introduces the following changes:

  1. Refactoring of Sync Committee Logic:

    • Updated the log_finality_update and log_optimistic_update functions to correctly calculate the size of the sync committee and the participation ratio. This ensures that the calculations are based on the correct sync committee size, improving the accuracy of the finality updates.
  2. Addition of Unsafe Signer Verification:

    • Introduced a new field verify_unsafe_singer in the OpStackClientBuilder struct. This optional boolean field allows for the configuration of unsafe signer verification, enhancing the flexibility and security of the client builder.

These changes aim to improve the overall functionality and security of the consensus mechanism. Please review the modifications and provide feedback.

@ncitron
Copy link
Collaborator

ncitron commented Feb 26, 2025

These changes have already been addressed in #529 and #530

@ncitron ncitron closed this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants