Improve readability of CButtonMapXml::IsValid()

a1rwulf · Oct 11, 2016 · 1cf4ae4 · 1cf4ae4
1 parent d1d343e
commit 1cf4ae4
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/storage/xml/ButtonMapXml.cpp b/src/storage/xml/ButtonMapXml.cpp
@@ -313,13 +313,12 @@ bool CButtonMapXml::Serialize(const FeatureVector& features, TiXmlElement* pElem
 
 bool CButtonMapXml::IsValid(const ADDON::JoystickFeature& feature)
 {
-  auto itValid = std::find_if(feature.Primitives().begin(), feature.Primitives().end(),
-    [](const ADDON::DriverPrimitive& primitive)
-    {
-      return primitive.Type() != JOYSTICK_DRIVER_PRIMITIVE_TYPE_UNKNOWN;
-    });
-
-  return itValid != feature.Primitives().end();
+  for (auto primitive : feature.Primitives())
+  {
+    if (primitive.Type() != JOYSTICK_DRIVER_PRIMITIVE_TYPE_UNKNOWN)
+      return true;
+  }
+  return false;
 }
 
 bool CButtonMapXml::SerializePrimitiveTag(TiXmlElement* pElement, const ADDON::DriverPrimitive& primitive, const char* tagName)