Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged gplayers to tmdbplayers #106

Open
wants to merge 1 commit into
base: tmdbhelper
Choose a base branch
from

Conversation

Goldenfreddy0703
Copy link

Hey there, a couple of weeks ago, GPlayers experienced some downtime. Consequently, I made the decision to integrate its players with TMDBPlayers. I successfully incorporated all the new players and also performed updates on several existing ones. While adding new players was straightforward, updating proved to be a bit challenging, mainly due to the comparison process. Nevertheless, I believe everything should now be accurate. If you like, feel free to merge this PR. If you notice anything wrong, please don't hesitate to message, and I'll do my best to fix it.

Thank you

✨ - Added 9lives Players
✨ - Added Absolution Players
✨ - Added Adina Players
✨ - Added Affenity Players
✨ - Added Amazon Players
✨ - Added Base19 Players
✨ - Added Buds Players
✨ - Added Coalition. Players
✨ - Added Dramacool Players
✨ - Added Dradis Players
✨ - Added Dynasty Players
✨ - Added Fen Players
✨ - Added Fenlight Players
✨ - Added Gaia Players
✨ - Added Hulu Players
✨ - Added Imdbtrailers Players
✨ - Added Kingpin Players
✨ - Added Kit Players
✨ - Added Luffy Players
✨ - Added Metv Players
✨ - Added Moria Players
✨ - Added Netflix Players
✨ - Added Pov Players
✨ - Added Quicksilver Players
✨ - Added Shazam Players
✨ - Added Thechains Players
✨ - Added Thelab Players
✨ - Added Thelabjr Players
✨ - Added Thepromise Players
✨ - Added Twilight Players
✨ - Added Unleashed Players
✨ - Added Wizz Players
✨ - Added Wutu Players
✨ - Added Youtube Players
✨ - Added Zoro Players
⚙️ - Updated Alvin Players
⚙️ - Updated Gaia Players
⚙️ - Updated Genocide Players
⚙️ - Updated Homelander Players
⚙️ - Updated Nightwing Players
⚙️ - Updated Scrubsv2 Players
⚙️ - Updated Thecrew Players

✨ - Added 9lives Players
✨ - Added Absolution Players
✨ - Added Adina Players
✨ - Added Affenity Players
✨ - Added Amazon Players
✨ - Added Base19 Players
✨ - Added Buds Players
✨ - Added Coalition. Players
✨ - Added Dramacool Players
✨ - Added Dradis Players
✨ - Added Dynasty Players
✨ - Added Fen Players
✨ - Added Fenlight Players
✨ - Added Gaia Players
✨ - Added Hulu Players
✨ - Added Imdbtrailers Players
✨ - Added Kingpin Players
✨ - Added Kit Players
✨ - Added Luffy Players
✨ - Added Metv Players
✨ - Added Moria Players
✨ - Added Netflix Players
✨ - Added Pov Players
✨ - Added Quicksilver Players
✨ - Added Shazam Players
✨ - Added Thechains Players
✨ - Added Thelab Players
✨ - Added Thelabjr Players
✨ - Added Thepromise Players
✨ - Added Twilight Players
✨ - Added Unleashed Players
✨ - Added Wizz Players
✨ - Added Wutu Players
✨ - Added Youtube Players
✨ - Added Zoro Players
⚙️ - Updated Alvin Players
⚙️ - Updated Gaia Players
⚙️ - Updated Genocide Players
⚙️ - Updated Homelander Players
⚙️ - Updated Nightwing Players
⚙️ - Updated Scrubsv2 Players
⚙️ - Updated Thecrew Players
Copy link
Contributor

@drinfernoo drinfernoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the fact that many of these seem to be basically the same addon (just based off of URL structure), there are a number of files that simply don't belong here, have duplicated players which already exist, or have made questionable changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is the same as the one included with TMDBHelper, so it shouldn't be here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is the same as the one included with TMDBHelper, so it shouldn't be here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is the same as the one included with TMDBHelper, so it shouldn't be here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is the same as the one included with TMDBHelper, so it shouldn't be here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is the same as the one included with TMDBHelper, so it shouldn't be here.

"priority" : 500,
"play_movie" : "plugin://plugin.video.thecrew/?action=play&title={title_+}&year={year}&imdb={imdb}&meta=%7B%22rating%22%3A+%22%22%2C+%22code%22%3A+%22{imdb}%22%2C+%22tmdb%22%3A+%22{id}%22%2C+%22imdb%22%3A+%22{imdb}%22%2C+%22year%22%3A+%22{year}%22%2C+%22duration%22%3A+%22%22%2C+%22plot%22%3A+%22{plot}%22%2C+%22votes%22%3A+%22%22%2C+%22title%22%3A+%22{title_+}%22%2C+%22fanart%22%3A+%22{fanart}%22%2C+%22tagline%22%3A+%22%22%2C+%22writer%22%3A+%22%22%2C+%22next%22%3A+%22%22%2C+%22poster%22%3A+%22{poster}%22%2C+%22mediatype%22%3A+%22movie%22%2C+%22director%22%3A+%22%22%2C+%22studio%22%3A+%22%22%2C+%22genre%22%3A+%22%22%2C+%22metacache%22%3A+true%2C+%22premiered%22%3A+%22{premiered}%22%2C+%22originaltitle%22%3A+%22{title_+}%22%2C+%22cast%22%3A+%5B%5B%22%22%5D%5D%2C+%22mpaa%22%3A+%22%22%2C+%22trailer%22%3A+%22plugin%3A%2F%2Fplugin.video.thecrew%2F%3Faction%3Dtrailer%26name%3D{title_+}%2B%2528{year}%2529%22%7D&t={now}",
"play_episode" : "plugin://plugin.video.thecrew/?action=play&title={title_+}&year={year}&imdb={imdb}&tvdb={id}&season={season}&episode={episode}&tvshowtitle={clearname_+}&premiered={firstaired}&meta=%7B%22rating%22%3A+%22%22%2C+%22code%22%3A+%22{imdb}%22%2C+%22tmdb%22%3A+{tmdb}%2C+%22imdb%22%3A+%22{imdb}%22%2C+%22year%22%3A+%22{year}%22%2C+%22duration%22%3A+%22%22%2C+%22plot%22%3A+%22{plot}%22%2C+%22votes%22%3A+%22%22%2C+%22thumb%22%3A+%22{thumbnail}%22%2C+%22title%22%3A+%22{title_+}%22%2C+%22tvdb%22%3A+%22{id}%22%2C+%22label%22%3A+%22{title_+}%22%2C+%22season%22%3A+%22{season}%22%2C+%22status%22%3A+%22%22%2C+%22poster%22%3A+%22{poster}%22%2C+%22tvshowtitle%22%3A+%22{clearname_+}%22%2C+%22mediatype%22%3A+%22episode%22%2C+%22studio%22%3A+%22%22%2C+%22genre%22%3A+%22%22%2C+%22banner%22%3A+%22{thumbnail}%22%2C+%22episode%22%3A+%22{episode}%22%2C+%22premiered%22%3A+%22{firstaired}%22%2C+%22fanart%22%3A+%22{fanart}%22%2C+%22trailer%22%3A+%22plugin%3A%2F%2Fplugin.video.thecrew%2F%3Faction%3Dtrailer%26name%3D{clearname_+}%22%7D&t={now}"
"priority" : 100,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this priority being changed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This player is the same as the one already included in this package, so it shouldn't be here.

@@ -2,8 +2,9 @@
"name" : "[COLORblue]Nightwing[/COLOR]",
"plugin" : "plugin.video.nightwing",
"priority" : 500,
"play_movie" : "plugin://plugin.video.nightwing/?action=play&title={title_+}&year={year}&imdb={imdb}&meta=%7B%22rating%22%3A+%22%22%2C+%22code%22%3A+%22{imdb}%22%2C+%22tmdb%22%3A+%22{id}%22%2C+%22imdb%22%3A+%22{imdb}%22%2C+%22year%22%3A+%22{year}%22%2C+%22duration%22%3A+%22%22%2C+%22plot%22%3A+%22{plot}%22%2C+%22votes%22%3A+%22%22%2C+%22title%22%3A+%22{title_+}%22%2C+%22fanart%22%3A+%22{fanart}%22%2C+%22tagline%22%3A+%22%22%2C+%22writer%22%3A+%22%22%2C+%22next%22%3A+%22%22%2C+%22poster%22%3A+%22{poster}%22%2C+%22mediatype%22%3A+%22movie%22%2C+%22director%22%3A+%22%22%2C+%22studio%22%3A+%22%22%2C+%22genre%22%3A+%22%22%2C+%22metacache%22%3A+true%2C+%22premiered%22%3A+%22{premiered}%22%2C+%22originaltitle%22%3A+%22{title_+}%22%2C+%22cast%22%3A+%5B%5B%22%22%5D%5D%2C+%22mpaa%22%3A+%22%22%2C+%22trailer%22%3A+%22plugin%3A%2F%2Fplugin.video.nightwing%2F%3Faction%3Dtrailer%26name%3D{title_+}%2B%2528{year}%2529%22%7D&t={now}",
"play_episode" : "plugin://plugin.video.nightwing/?action=play&title={title_+}&year={year}&imdb={imdb}&tvdb={id}&season={season}&episode={episode}&tvshowtitle={clearname_+}&premiered={firstaired}&meta=%7B%22rating%22%3A+%22%22%2C+%22code%22%3A+%22{imdb}%22%2C+%22tmdb%22%3A+{tmdb}%2C+%22imdb%22%3A+%22{imdb}%22%2C+%22year%22%3A+%22{year}%22%2C+%22duration%22%3A+%22%22%2C+%22plot%22%3A+%22{plot}%22%2C+%22votes%22%3A+%22%22%2C+%22thumb%22%3A+%22{thumbnail}%22%2C+%22title%22%3A+%22{title_+}%22%2C+%22tvdb%22%3A+%22{id}%22%2C+%22label%22%3A+%22{title_+}%22%2C+%22season%22%3A+%22{season}%22%2C+%22status%22%3A+%22%22%2C+%22poster%22%3A+%22{poster}%22%2C+%22tvshowtitle%22%3A+%22{clearname_+}%22%2C+%22mediatype%22%3A+%22episode%22%2C+%22studio%22%3A+%22%22%2C+%22genre%22%3A+%22%22%2C+%22banner%22%3A+%22{thumbnail}%22%2C+%22episode%22%3A+%22{episode}%22%2C+%22premiered%22%3A+%22{firstaired}%22%2C+%22fanart%22%3A+%22{fanart}%22%2C+%22trailer%22%3A+%22plugin%3A%2F%2Fplugin.video.nightwing%2F%3Faction%3Dtrailer%26name%3D{clearname_+}%22%7D&t={now}",
"is_resolvable" : "true",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this addon now support resolvable links?

"plugin" : "plugin.video.dramacool",
"priority" : 500,
"is_resolvable" : "false",
"search_movie" : [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting in this one is awfully unconventional 🤔

@@ -0,0 +1,8 @@
{
"name" : "[COLOR snow]wutu[/COLOR] (Source Select)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this one colored, when the rest of the players for Wutu are not?

@Goldenfreddy0703
Copy link
Author

Your right, for now, I'm going to work on this more and see what needs to be added and what needs to be modified and everything. Thank you for reviewing these.

@Goldenfreddy0703
Copy link
Author

Hey so im actually going to close this for now and work on this for a later date, reason why is cause i worked on this pr today on my laptop and i should have done this on my desktop. Will have this reopened when finished. Thank you

@drinfernoo
Copy link
Contributor

drinfernoo commented Apr 7, 2024

No need to close this one; you can just make the modifications as a new commit on the same branch and they'll show up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants