Override time delay #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atangwbd
reviewed
Apr 6, 2023
|
|
||
| def to_feature_config(self) -> str: | ||
| tm = Template(""" | ||
| { | ||
| key: [{{key_columns}}] | ||
| featureList: [{{feature_names}}] | ||
| {% if query.overrideTimeDelay is defined %} |
There was a problem hiding this comment.
Suggested change
| {% if query.overrideTimeDelay is defined %} | |
| {% if query.overrideTimeDelay %} |
atangwbd
reviewed
Apr 6, 2023
| @@ -3,29 +3,66 @@ | |||
| from loguru import logger | |||
| from feathr.definition.feathrconfig import HoconConvertible | |||
|
|
|||
| class ConflictsAutoCorrection(): | |||
There was a problem hiding this comment.
Oh interesting. This is updated code from the official feathr repo that hasn't been merged into this repo yet right?
atangwbd
approved these changes
Apr 6, 2023
atangwbd
reviewed
Apr 6, 2023
Comment on lines
+20
to
+21
| if override_time_delay: | ||
| self.overrideTimeDelay = override_time_delay |
There was a problem hiding this comment.
Suggested change
| if override_time_delay: | |
| self.overrideTimeDelay = override_time_delay | |
| self.overrideTimeDelay = override_time_delay |
small nit: but can be expressed a bit cleaner like this and the suggestion in L28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #XXX
How was this PR tested?
Does this PR introduce any user-facing changes?