ci: Add zizmor pre-commit hook #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #311 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 5 5
Lines 413 413
Branches 92 92
=======================================
Hits 392 392
Misses 15 15
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Even though it's pretty new, zizmor has already established itself as a very potent static analysis tool for GitHub Actions. Let's give it a go to see what it has to say on our current CI.
No persisting credentials, and the test and docs jobs in the test workflow each get job-scoped content writing permissions.
No persisting credentials, and the test and docs jobs in the test workflow each get job-scoped content writing permissions. mike creates an automated commit on release/main push, so it does need credentials - those are then explicitly set. Fixes the mike action by putting inputs as environment variables. The alias is explicitly not quoted, since otherwise mike would pick it up, and it cannot deal with an empty string alias.
nicholasjng
force-pushed
the
zizmor-pre-commit
branch
from
6e7eba2 to
05d2454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though it's pretty new, zizmor has already established itself as a very potent static analysis tool for GitHub Actions. Let's give it a go and see what it has to say on our current CI.
Maintainer is very active and a great guy by the way, I've worked with him previously on abi3audit.
Some reading on zizmor: