Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-double-entries in menu #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

capt-d
Copy link

@capt-d capt-d commented Dec 25, 2016

User's *.desktop entries are overwriting system's ones. It is based on files' names for specified category. Patch in attachment.

User's *.desktop entries are overwriting system's ones. It is based on files' names for specified category. Patch in attachment.
@JDM1492
Copy link

JDM1492 commented Sep 2, 2017

http://standards.freedesktop.org/menu-spec/menu-spec-latest.html says:
"When two desktop entries have the same name, the one appearing earlier in the path is used."

The spec is referring to the "Name" key in the file, not the file name. Currently, duplicates are the result of not scanning user directories first and not rejecting additional occurrences of names.

This change does not correctly comply with the freedesktop.org spec since it uses file names. Menu editors which generate local .desktop files with names differing from the system ones will stop working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants