Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Abstract and Intro Sections #49

Merged
merged 9 commits into from
Nov 6, 2024

Conversation

wthayer
Copy link
Contributor

@wthayer wthayer commented Nov 6, 2024

I've reviewed @aaomidi's latest branch and overall I am happy with everything that has been removed and simplified.

This PR suggests some changes to the descriptive language in the document. I attempted to address @jdkasten's comments on @aaomidi's PR. I will note that I decided not to reformat the Challenge Definition and Challenge Fulfillment sections as @jdkasten suggested - I find the existing format (including subsections, bullets, and numbering) to be easier to consume than the RFC 8737 format.

I would be really happy if we could get this published soon as draft -02 - with or without my changes. Once we have a stable draft I can work with the CAB Forum on the needed BR changes.

Looking forward to your feedback.

Copy link
Collaborator

@jdkasten jdkasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Wayne and Amir!

@aaomidi
Copy link
Owner

aaomidi commented Nov 6, 2024

Thank you Wayne. I just got home from accompanying a family member for a medical procedure and I'll check on it later tonight!

@aaomidi aaomidi merged commit c25912a into aaomidi:amir/remove_scopes Nov 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants