Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 11.x Compatibility #58

Merged
merged 6 commits into from
May 15, 2024

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

  • Checkout the l11-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 11. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/fast-paginate.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "hammerstone/fast-paginate": "dev-l11-compatibility",
    }
}

Finally, run: composer update

@scajal
Copy link

scajal commented Mar 15, 2024

Any news on this?

This was referenced Mar 17, 2024
@irsyadadl
Copy link

Hello, is there any updates @aarondfrancis ?

@riskihajar
Copy link

everyone waiting 🕚

@irsyadadl
Copy link

Maybe we just uninstall this, and use regular laravel pagination. At least until this package support L11.

@jbraband
Copy link

The replies here are on the verge of becoming content!

@drhoussem
Copy link

Any updates?

@scajal
Copy link

scajal commented Apr 25, 2024

I personally decided to stop using the package in the projects where it was being used, at least until this is merged.

@aarondfrancis aarondfrancis merged commit 1fac167 into aarondfrancis:main May 15, 2024
23 checks passed
@aarondfrancis
Copy link
Owner

Thanks for your patience! Merged. Gonna try to look at the other PRs real quick before tagging a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants