Add per-capita option #25
Conversation
…n data Population data by country comes from World Bank
|
This is ready for a review. I've added a dropdown where you can choose between cases "absolute" and "per capita". |
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
This file appears to be unrelated to this pull request
| @@ -239,6 +243,11 @@ Vue.component('graph', { | |||
| this.$emit('update:day', this.dates.length); | |||
| }, | |||
|
|
|||
| selectedUnit() { | |||
| console.log('selectedUnit: ' + this.selectedUnit); | |||
| if (urlParameters.has('unit')) { | ||
| let myUnit = urlParameters.get('unit').toLowerCase(); | ||
|
|
||
| if (myUnit == 'per+capita') { |
There was a problem hiding this comment.
In addition to +, %20 is a valid encoding of too, right?
|
I was going to add a pro capita toggle! I'm happy you're already working on it! It would be great! |
|
FYI, you should read the comment @aatishb wrote on this topic some time ago: #30 (comment) |
|
Just want to remind folks of our code of conduct, which I’m excerpting here. Be respectful. Disagreement is not an opportunity to attack someone else's thoughts or opinions. Although views may differ, remember to approach every situation with patience and care. |
|
@mrelg this was just an FYI. Nothing more than "hey BTW, there is a discussion about that, maybe it could be useful to read it". I personally run this branch locally on a daily bases, as it's useful to me alongside the version on the master. Yet, I understand and respect @aatishb work and opinion. Anyone who doesn't is free to run their own fork or better, to contribute to the discussion respectfully. |
|
@mrelg We have deleted your comments for being off-topic and not living up to our code of conduct. Just to be clear, all of these comments are being posted on a public thread. As far as we can tell, @noelmace’s comment was not addressed to you but to the whole audience on this thread. You may inadvertently be getting email notifications from this comment thread, which you are free to unsubscribe from. We will also be deleting any further off-topic comments. Just as a heads up, repeated code of conduct violations will result in being blocked from this repository. |
Addresses #1