Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/324 #342

Closed
wants to merge 3 commits into from
Closed

Task/324 #342

wants to merge 3 commits into from

Conversation

thegrubster
Copy link
Contributor

@thegrubster thegrubster commented Nov 13, 2023

Description

I have gone through the files of the repository and removed the ones that were no longer in use, with one exception. Currently, it is unknown if codecov.yml is in use or not, as the codecov bot does not report code coverage on pull requests like it does on the weekplanner. However, after running the github actions locally it states that a code coverage report is being uploaded to codecov, meaning it is likely in use, and just not setup correctly.

Fixes #324

Type of change

  • Deletion

How Has This Been Tested?

I have run unit and integration tests after each file was deleted and no issues occurred.

Development Configuration
OS: NixOS 23.11pre534806.5e4c2ada4fcd (Tapir) x86_64
Kernel: 6.1.57
.NET: 8.0.100-rc.1.23455.8

Definition of Done

  • When the purpose of all remaining files can be explained.
    • Only the files from the description was considered.

@JMyrtue
Copy link
Contributor

JMyrtue commented Nov 14, 2023

More files was found to be redundant - a new pull request is made with these changes.

@JMyrtue JMyrtue closed this Nov 14, 2023
@EMojoKrogh EMojoKrogh deleted the task/324 branch November 17, 2023 10:08
@EMojoKrogh EMojoKrogh restored the task/324 branch November 17, 2023 10:08
@EMojoKrogh EMojoKrogh deleted the task/324 branch November 17, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused resources
2 participants