Task/324 #343
Merged
Task/324 #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMyrtue
requested review from
pmagnu,
Karachnor,
bafinouri91,
RasmusBredfort and
Ali-Sulaiman
RasmusBredfort
approved these changes
Nov 15, 2023
pmagnu
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have gone through the files of the repository and removed the ones that were no longer in use, with one exception. Currently, it is unknown if
codecov.ymlis in use or not, as the codecov bot does not report code coverage on pull requests like it does on the weekplanner. However, after running the github actions locally it states that a code coverage report is being uploaded to codecov, meaning it is likely in use, and just not setup correctly.Later the wwwroot folder, bower.json and bundleconfig.json was removed.
Fixes #324
Type of change
How Has This Been Tested?
I have run unit and integration tests after each file was deleted and no issues occurred.
Development Configuration
OS: NixOS 23.11pre534806.5e4c2ada4fcd (Tapir) x86_64
Kernel: 6.1.57
.NET: 8.0.100-rc.1.23455.8
Definition of Done