resolves issues regarding UpdateDays method. Moves some funcitonality… #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from repositories to service project.
JMyrtue
added a commit
that referenced
this pull request
Nov 24, 2023
* Added repository DI to the RepositoryExtension * Adding missing service DI, and commenting on further improvements * resolves issues regarding UpdateDays method. Moves some funcitonality from repositories to service project. (#355) * Department entities giraf service refactor (#356) * removed methods from department DTO into service * removed dbcontext from service layer in GirafService, now renamed UserService * renamed girafService dependency in AccountController --------- Co-authored-by: Schoogle <[email protected]> * fixes minor issues after merge --------- Co-authored-by: Kristian <[email protected]> Co-authored-by: Schoogle <[email protected]>
JMyrtue
added a commit
that referenced
this pull request
Dec 11, 2023
* Added project structure * Renamed test projects * Update unit_test.yml * Update integration_test.yml * Update unit_test.yml * removed unwanted folders * files moved into corresponding projects of new structure * added extension methods for IserviceCollection * further additions from forgotten save * Fixing ef repo (#350) * fixed alot of namespace issus regarding the Repoistories. Added nuget packages * Fixed multiple errors regarding the repository, missing updateday functionality * Renaming of girafrest to GirafAPI * Distributed DTOs into folders in entity project; Distributed interfaces into folders in reposity project (#349) --------- Co-authored-by: Kristian <[email protected]> * Service ref fix (#353) * changes namespaces where relevant, and solves trivial references * further error fixes to server project * Entity ref fix (#352) * fixed namespaces in entity and files using them * fixed some references in entities project --------- Co-authored-by: Schoogle <[email protected]> --------- Co-authored-by: Schoogle <[email protected]> * Fixing api refs (#354) * fixing namespaces and packages in API * removes sharedMethods from service, by creating weekService, and dependency injecting it into a controller. --------- Co-authored-by: Desktop <[email protected]> Co-authored-by: Andreas Würtz <[email protected]> * remove old Model usings * Di register (#357) * Added repository DI to the RepositoryExtension * Adding missing service DI, and commenting on further improvements * resolves issues regarding UpdateDays method. Moves some funcitonality from repositories to service project. (#355) * Department entities giraf service refactor (#356) * removed methods from department DTO into service * removed dbcontext from service layer in GirafService, now renamed UserService * renamed girafService dependency in AccountController --------- Co-authored-by: Schoogle <[email protected]> * fixes minor issues after merge --------- Co-authored-by: Kristian <[email protected]> Co-authored-by: Schoogle <[email protected]> * Remove context from weektemplatecontroller (#358) * Remove direct access to db Department table through weektemplate controller * remove all use of girafdbcontext in week template controller + setup weektemplate repository * add WeekTemplateService and make weektemplate controller use service instead of repository --------- Co-authored-by: Andreas Würtz <[email protected]> * Move entity functions (#359) * Added moved Updatefrom and updateWeekdaycolors to SettingService * Deleted functions Initialize_data(), and moved initialization to constructors * Moved InitializedWeekDayColors initialization to settings constructor, since it was only used in conjunction with the constructor --------- Co-authored-by: EMojoKrogh <[email protected]> * moved DBinitialize to API project, and fixed all issues * remaining changes * changes * Merge (#366) * arch * hej * hej * added services * removed pictogram service * removed redundant packages, tested dotnet ef database update and dotnet run * Found the issue its the UserIcon in GirafUser and in the constructor * removed dbcontext from startup * added role repo to constructer in service * Fix two byte null errors * added settings for weekdaycolors to girafuser * forgot to initialize list * test * removing logging * removed serilog * logging removed * logging removed * Remove prints * removed remaining log problems from programoptions * removed girafextensions * refactor logic from entities * refactoring of helper functions * started resolving unit test errors * resolving more unit test issues * no build errors in unit tests * fixed account controller test for girafroles * Missing 3 tests * fixed 1 integration test * dto to nullable * Changed xunit * removed userservice from find members * resolved another test * user role * changed * fixed some error * another unit test fixed * enabled last test * removed unneacessary extra method calls in ReadPictograms_Succes test, now works * Changed mock setup for UpdatepictogramInfo_Succes to rely less on other dependencies * changed DeletePictogram_Success test to rely on less denpendencies * removed commented-out functions, that have been moved --------- Co-authored-by: Kristian <[email protected]> Co-authored-by: Schoogle <[email protected]> Co-authored-by: jojens15 <[email protected]> * minor fixes --------- Co-authored-by: Kristian <[email protected]> Co-authored-by: Kristian Sørensen <[email protected]> Co-authored-by: Schoogle <[email protected]> Co-authored-by: Andreas Würtz <[email protected]> Co-authored-by: EMojoKrogh <[email protected]> Co-authored-by: Esben <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.