-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #705 #971
Open
Thuyhaile
wants to merge
6
commits into
develop
Choose a base branch
from
Issue#705
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Issue #705 #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neither me or Andreas are on the 5th semester. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #971 +/- ##
=========================================
- Coverage 29.8% 29.7% -0.1%
=========================================
Files 47 47
Lines 2383 2390 +7
=========================================
Hits 712 712
- Misses 1671 1678 +7
|
omegaMindCoder619
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the user is in the 'Tilføj ugeplan' UI and chooses the Edit mode to delete a week plan (for example week 25), and then attempts to create a new one with the same week as the deleted week plan, the app will indicate that a week plan already exists.
Fixes #<705>
Update the stream after deleting a week plan so that the 'Warning popup' will not appear again.
Type of change
How Has This Been Tested?
Android Platform: emulation is carried out using Android Studio on Windows computer
iOS Platform: emulation is carried out using Xcode on MacBook
Development Configuration
Flutter version: 3.3.8
Dart version: 2.18.4
Checklist: