Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #705 #971

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Issue #705 #971

wants to merge 6 commits into from

Conversation

Thuyhaile
Copy link
Contributor

@Thuyhaile Thuyhaile commented Nov 7, 2023

Description

When the user is in the 'Tilføj ugeplan' UI and chooses the Edit mode to delete a week plan (for example week 25), and then attempts to create a new one with the same week as the deleted week plan, the app will indicate that a week plan already exists.
image

Fixes #<705>

Update the stream after deleting a week plan so that the 'Warning popup' will not appear again.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Android Platform: emulation is carried out using Android Studio on Windows computer
iOS Platform: emulation is carried out using Xcode on MacBook

Development Configuration

Flutter version: 3.3.8
Dart version: 2.18.4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas, if necessary
  • I have made corresponding changes to the documentation, if necessary
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, if necessary
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have Acceptance Tested this on an iOS device
  • I have Acceptance Tested this on an Android device

@emilnormann
Copy link
Contributor

Neither me or Andreas are on the 5th semester.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #971 (c68598b) into develop (f5f8466) will decrease coverage by 0.1%.
Report is 1 commits behind head on develop.
The diff coverage is 0.0%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #971     +/-   ##
=========================================
- Coverage     29.8%   29.7%   -0.1%     
=========================================
  Files           47      47             
  Lines         2383    2390      +7     
=========================================
  Hits           712     712             
- Misses        1671    1678      +7     
Files Coverage Δ
lib/blocs/weekplan_selector_bloc.dart 65.7% <0.0%> (-3.3%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create new weekplan after deleting old weekplan for the same week
3 participants