Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix issue on RiskStewards contract name for same chain pools #27

Merged

Conversation

MartinGbz
Copy link
Contributor

@MartinGbz MartinGbz commented Jan 15, 2025

Issue: the generator doesn't use the right RiskStewards contract name on the file it generates. It uses the chain name instead of the pool name. So pools like Lido or Etherfi use the same RiskStewardsEthereum instead of their own.
This leads to the execution of calldatas that return errors because they are simulated on the wrong RiskStewards address.

Instead of getting the chain name to compute the RiskStewards contract name, we now use the suffix of Pool names.
So: AaveV3EthereumLido => EthereumLido

Tested locally contract on Core and Prime pool: ✅

@brotherlymite brotherlymite merged commit 72e78d7 into aave-dao:main Jan 15, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants