Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use fancy quotes in the conf.py template #87

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

tiwo
Copy link

@tiwo tiwo commented May 21, 2017

This is a three-character patch to partially fix #86 that prevented me from doing ablog build right after ablog start under Windows.

I'm still not quite sure what happened (When does Python assume a cp1252 encoding in the first place? If fancy quotes in a comment break the build, why are umlauts in blog_title working?) - but no matter what, I'm confident nobody is going to miss the fancy quotes.

cf. issue abakan-zz#86.

(also correct a typo on the same line)
@tiwo
Copy link
Author

tiwo commented May 21, 2017

Travis CI fails

@rayalan
Copy link

rayalan commented Dec 13, 2017

Thanks for the patch; I needed it for Sphinx 1.6.5/Python 3.6. Would be great to see this merged and released.

rayalan added a commit to rayalan/ablog-deprecated that referenced this pull request Dec 24, 2017
@nabobalis
Copy link

This has now been merged into here.
Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ablog build" fails in a fresh repository, encoding issues with conf.py
3 participants