Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PPSApi class and separate different modules #10

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

abarghoud
Copy link
Owner

Resolves #2

  • Created a steps system to avoid duplication, this allows the PPSApi easy to be more dumb
  • Created a specific module for PPS related services
  • Created a SharedModule for shared generic services

@abarghoud abarghoud self-assigned this Nov 10, 2024
Copy link

nx-cloud bot commented Nov 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5ad2980. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Collaborator

@Romain-Portanguen Romain-Portanguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one feedback against a console.log (probably an oversight?). As for the rest, magnificent! It's much cleaner and more readable this way. GG 😍

# Conflicts:
#	apps/api/src/app/pps/third-party/pps-api.spec.ts
#	apps/api/src/app/pps/usecase/pps-generator-usecase.spec.ts
@abarghoud abarghoud merged commit eaaae94 into main Nov 12, 2024
2 checks passed
@abarghoud abarghoud deleted the refactor-pps-api-class branch November 12, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor PPSApi class to handle each step in a separate class
2 participants