-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Godot 4.3 #149
Update for Godot 4.3 #149
Conversation
The release.yml workflow also needs to change so that it updates the |
Ooh what is that?!?! |
If this is like regex then we have to check if the version string is always the full one like "4.3.0", because if its "4.3" i imagine it would break. |
If im understand this correctly: godot-ci/.github/workflows/release.yml Lines 17 to 19 in bd9eea1
it's extracting the version string from this repos tags, which don't have the x.y.z format for every release. |
Should probably be removed once abarichello/godot-ci#149 is merged.
I've reworked the script to not require a new However, since Godot does not use |
Do we want to update the mono image's version ARG while were here? I get the release.yml overrides it but it looks like we're trying to clean up across the board. |
`editor_settings.tres` is now split per minor version since 4.3. This also updates mono.Dockerfile to match the main Dockerfile.
Done. The Mono Dockerfile now matches the main one more or less, with support for exporting to Android and using rcedit for Windows exports. I haven't tested it though. |
editor_settings.tres
is now split per minor version since 4.3.This also updates
mono.Dockerfile
to match the mainDockerfile
.