Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Godot 4.3 #149

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Update for Godot 4.3 #149

merged 1 commit into from
Oct 7, 2024

Conversation

Calinou
Copy link
Collaborator

@Calinou Calinou commented Aug 22, 2024

editor_settings.tres is now split per minor version since 4.3.

This also updates mono.Dockerfile to match the main Dockerfile.

@Calinou Calinou added the enhancement New feature or request label Aug 22, 2024
@OverloadedOrama
Copy link
Contributor

The release.yml workflow also needs to change so that it updates the GODOT_VERSION_MAJOR_MINOR argument, like it does for GODOT_VERSION

@Kiisu-Master
Copy link

Ooh what is that?!?!

@Kiisu-Master
Copy link

If this is like regex then we have to check if the version string is always the full one like "4.3.0", because if its "4.3" i imagine it would break.

@Kiisu-Master
Copy link

If im understand this correctly:

REF_NAME=${{ github.ref_name }}
echo "version=${REF_NAME%-*}" >> $GITHUB_OUTPUT
echo "release_name=${REF_NAME#*-}" >> $GITHUB_OUTPUT

it's extracting the version string from this repos tags, which don't have the x.y.z format for every release.

OverloadedOrama added a commit to Orama-Interactive/Pixelorama that referenced this pull request Aug 23, 2024
Should probably be removed once abarichello/godot-ci#149 is merged.
@Calinou
Copy link
Collaborator Author

Calinou commented Aug 24, 2024

I've reworked the script to not require a new GODOT_MAJOR_MINOR_VERSION variable (thanks to Bash variable substitution).

However, since Godot does not use .0 for the first patch release, this means 4.3 would be trimmed into 4. Perhaps using something to always trim the string to 3 characters would be better, although it'll break if we ever reach 4.10.

@RealrealChaiR
Copy link

Do we want to update the mono image's version ARG while were here? I get the release.yml overrides it but it looks like we're trying to clean up across the board.

https://github.com/abarichello/godot-ci/pull/149/files#diff-d79da252bb700d7827e34d08ba8526c6a57642e0e0170d22580eddb090fd418eL22

`editor_settings.tres` is now split per minor version since 4.3.

This also updates mono.Dockerfile to match the main Dockerfile.
@Calinou
Copy link
Collaborator Author

Calinou commented Aug 24, 2024

Do we want to update the mono image's version ARG while were here? I get the release.yml overrides it but it looks like we're trying to clean up across the board.

#149 (files)

Done. The Mono Dockerfile now matches the main one more or less, with support for exporting to Android and using rcedit for Windows exports. I haven't tested it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants