Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nyc data #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update nyc data #16

wants to merge 2 commits into from

Conversation

annama2019
Copy link
Contributor

Hi Alex,

Here are the updated nyc data, I tried many ways to deal with the "index out of bound" error we discussed in our meeting but they all didn't work out. I tried to make the open_zipfile method move on to another csv file in the zip folder if it get an empty data frame. I think this should fix the problem but it just didn't worked out. So I am out of fixing methods...

Also something interrupt my computer when I was running through the scraper data so that I only had the station files until 2016.10 when that interruption occurred. So I changed the scraper a bit so that it would download only the 2016.11, 2016.12 and then 2017-2019 files for me (since I already have the previous one downloaded and I don't want to download them again). So the output for the scraper script would seem a bit weird based on the above reasons. (I changed the scraper script back so that it could download all the station files when I finish downloading my files)

Best,
Anna

@aberke
Copy link
Owner

aberke commented Dec 17, 2019

Hi Anna,
I appreciate your effort in continuing to work on this! Given that the output is incomplete, it might be better not to merge it for now. Unless you can show that the output has better data than before.
Otherwise, great effort and have a great holiday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants