Fix: Safer way of filtering out private lesson plans from resource view

aberonni · Jan 24, 2024 · 3182523 · 3182523
1 parent 94d6f9e
commit 3182523
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/server/api/routers/resource.ts b/src/server/api/routers/resource.ts
@@ -137,14 +137,20 @@ export const resourceRouter = createTRPCRouter({
             },
           },
           lessonPlanItems: {
+            where: {
+              section: {
+                lessonPlan: {
+                  private: false,
+                },
+              },
+            },
             select: {
               section: {
                 select: {
                   lessonPlan: {
                     select: {
                       id: true,
                       title: true,
-                      private: true,
                     },
                   },
                 },
@@ -178,8 +184,6 @@ export const resourceRouter = createTRPCRouter({
       const lessonPlans: { id: string; title: string }[] = [];
 
       lessonPlanItems.forEach(({ section: { lessonPlan } }) => {
-        // filtering out private lesson plans
-        if (lessonPlan.private) return;
         lessonPlans.push(lessonPlan);
       });