Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream changed some things w/ how grammar works in ggerganov/llama.cpp#8508 and ggerganov/llama.cpp#8093 - may also want to check if
llama_grammar_init
return value is null, since this is what's done now rather than throwing an error.Old argument order for
llama_grammar_accept_token
was:llama_grammar_accept_token(ctx, grammar, token)
Now this is:
llama_grammar_accept_token(grammar, ctx, token)
Can test with
Should fix #1623