Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1825

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #1825

wants to merge 1 commit into from

Conversation

Nik-Kras
Copy link

@Nik-Kras Nik-Kras commented Nov 8, 2024

No description provided.

@ExtReMLapin
Copy link
Contributor

Average 'I can't code but I want to be in the contributors list' PR

@richdougherty
Copy link
Contributor

richdougherty commented Nov 24, 2024

Hi @Nik-Kras, I think it's nice to keep the text clean. My suggestion is that I would probably go lighter on the changes and just stick to obvious grammar errors (The model will will format), and not just minor style changes. This is because the changes add extra diffs to the code which can make history harder to trace. If you stick to fixes it will also make it easier for the maintainer to merge.

I'm reminded of this first PR on a project I worked on, which got a bit famous with a blog post: playframework/playframework#616. Hopefully that will encourage you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants