Skip to content

Commit

Permalink
Install grumpy-tools before building grumpy-runtime
Browse files Browse the repository at this point in the history
`pip2 install grumpy-runtime` fails with the ERROR
grumpyhome#113 (comment)
because it relies on `grumpy-tools`.

`grumpy-tools` packages is specified in `setup.py` as a
dependency, and it doesn't work, because for the build process to
succeed, the dependency should already exist at the time `setup.py`
is executed.

The official workaround is `pyproject.toml` from PEP-518
pypa/pip#2381
  • Loading branch information
abitrolly committed Oct 10, 2019
1 parent 994ea3c commit 687d517
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions grumpy-runtime-src/MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,5 @@ global-exclude *.egg-info/*
global-exclude *__pycache__*

recursive-exclude grumpy-tools-src *.go

include pyproject.toml
2 changes: 2 additions & 0 deletions grumpy-runtime-src/pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[build-system]
requires = ["grumpy-tools > 0.2.2"]

0 comments on commit 687d517

Please sign in to comment.