Merge latest master #8
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 19, 2016 11:02
Slash and burn
BIG-4192 - Use `rep-cpp`
Bump version and update maintainer
would have saved me lots of hassle
For Python 2, the `Robots.__str__` function was returning a unicode object
instead of a `str` (bytes) object. This had two problems:
* For invalid UTF-8, the `decode()` method was raising a
UnicodeDecodeError. Really, we should just be returning the raw bytes so we
should not be worrying about encodings here. However, in Python 3 this
problem will still exist. I'm not sure what the right answer is here,
if we want to use `.decode('utf-8', 'replace')`? In this case --
`Robots.__str__` is just debug information -- we might want to just do
that.
* Even for valid UTF-8, if there are non-ASCII characters, Python 2 will
convert the unicode object back to bytes via the `str()` function,
using the ASCII encoding. This will result in a UnicodeEncodeError.
This problem was Python 2 specific.
For Python 2, both these have been fixed in this commit.
…rors Fix UnicodeDecode/Encode errors for Python 2
Log errors that happen when fetching from cache
For some reason, cachetools version 3 (released on 2018-11-04) removed the ability to pass in a `missing` function; apparently this made the implementation cleaner (see tkem/cachetools#58). Unfortunately we use this functionality here. Rather than require version 2 of cachetools, I thought it would be better to allow reppy to be used with the new version. Unfortunately, that means a reimplementation of pretty much exactly what was removed from cachetools. I found this because we have a project which uses reppy and its tests suddenly broke, because pip automatically installed the newer version of cachetools.
so we test reppy working with the new version of cachetools -- cachetools 3
Rewrite functionality removed from cachetools 3
I consider cachetools breaking current/old reppy to be enough cause to bump the version of reppy. For background, that was fixed in reppy here: #103
release 0.4.12
Support len(agent)
Make sitemaps a list
* Updates to requirements.txt to include all necessary parts & pin versions. * Updated version number for fresh target, & made contact info consistent.
A case of not including what we use - relying on other headers to include what intend to include, when what they include should be considered opaque, to us.
Point to new rep-cpp, which points to new url-cpp, fixing <limits>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to track upstream (which has diverged so much that this PR will likely never ever be merged)