Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed false positive occuring in issue #4022 #4034

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fixed false positive occuring in issue #4022 #4034

wants to merge 1 commit into from
+54 −1

Conversation

lyr-ast
Copy link
Contributor

@lyr-ast lyr-ast commented Dec 21, 2024 •
edited
Loading

Fixes #4022

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

AyanSinhaMahapatra
AyanSinhaMahapatra requested changes Jan 14, 2025
View reviewed changes
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyr-ast thanks for your PR!
Could you check #4022 (comment), we need a couple more new rules here to close this issue.

@lyr-ast
Copy link
Contributor Author

lyr-ast commented Jan 14, 2025

Yeah, sure! I've just pushed the changes. Please check if there are any other issues.

@lyr-ast lyr-ast closed this Jan 14, 2025
@lyr-ast lyr-ast reopened this Jan 14, 2025
@lyr-ast lyr-ast force-pushed the issue-#4022 branch 9 times, most recently from 0a26e33 to b4a7b61 Compare January 17, 2025 22:05
@lyr-ast
Fixed False Positive detection for amazon-sl license by adding rules …
ae90f4b 
…for mit license and updating rules for amazon-sl license. issue aboutcode-org#4022

Signed-off-by: Aayush Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyanSinhaMahapatra AyanSinhaMahapatra AyanSinhaMahapatra requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False Positive: Incorrect detection of amazon-sl license expression
2 participants
@lyr-ast @AyanSinhaMahapatra