Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

React Native: Mobile application development tutorial #526

Merged
merged 10 commits into from
Oct 20, 2023

Conversation

masum-ulu
Copy link
Contributor

@masum-ulu masum-ulu commented Oct 9, 2023

Resolves https://github.com/volosoft/volo/issues/14262

This PR includes mobile application development tutorial with react native


@EngincanV Can you please check the structure of folder

@masum-ulu masum-ulu added the documentation Improvements or additions to documentation label Oct 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Images automagically compressed by Calibre's image-actions

Compression reduced images by 9%, saving 82.20 KB.

Filename Before After Improvement Visual comparison
en/tutorials/mobile/images/react-native/author-list-with-options.png 73.56 KB 67.15 KB -8.7% View diff
en/tutorials/mobile/images/react-native/author-list.png 78.56 KB 71.49 KB -9.0% View diff
en/tutorials/mobile/images/react-native/authors-in-book-form.png 66.92 KB 59.80 KB -10.6% View diff
en/tutorials/mobile/images/react-native/book-list-with-author.png 63.83 KB 62.36 KB -2.3% View diff
en/tutorials/mobile/images/react-native/book-list-with-options.png 65.57 KB 58.78 KB -10.4% View diff
en/tutorials/mobile/images/react-native/book-list.png 65.87 KB 58.77 KB -10.8% View diff
en/tutorials/mobile/images/react-native/book-store-menu-item.png 69.74 KB 62.11 KB -10.9% View diff
en/tutorials/mobile/images/react-native/create-book-icon.png 67.17 KB 60.25 KB -10.3% View diff
en/tutorials/mobile/images/react-native/create-book.png 61.93 KB 55.23 KB -10.8% View diff
en/tutorials/mobile/images/react-native/delete-author-alert.png 86.67 KB 78.60 KB -9.3% View diff
en/tutorials/mobile/images/react-native/delete-book-alert.png 74.21 KB 67.08 KB -9.6% View diff
en/tutorials/mobile/images/react-native/delete-book.png 60.58 KB 58.96 KB -2.7% View diff
en/tutorials/mobile/images/react-native/update-book.png 62.43 KB 55.87 KB -10.5% View diff
en/tutorials/mobile/images/react-native/update-delete-book-button-visibility.png 18.17 KB 16.57 KB -8.8% View diff

544 images did not require optimisation.

Copy link
Contributor

@EngincanV EngincanV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you delete the en/tutorials/mobile/image folder and move all the images in this folder to the main images folder (https://github.com/abpio/abp-commercial-docs/tree/dev/en/images)?

Copy link
Contributor

@EngincanV EngincanV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation is really good and shows all related code blocks to build up the application. But I think that we need to describe each section plainly, I mean each section needs to have short text that explains what the added code does, in my opinion.

en/tutorials/mobile/react-native.md Outdated Show resolved Hide resolved
@masum-ulu
Copy link
Contributor Author

masum-ulu commented Oct 10, 2023

The documentation is really good and shows all related code blocks to build up the application. But I think that we need to describe each section plainly, I mean each section needs to have short text that explains what the added code does, in my opinion.

I've update the tutorial, I tried to add descriptions. Can you please review again when you can @EngincanV
I'll update demo project link after merge https://github.com/volosoft/abp-commercial-samples/pull/54

@hikalkan hikalkan added this to the 8.0 milestone Oct 11, 2023
@masum-ulu masum-ulu requested a review from hikalkan October 16, 2023 10:57
@hikalkan hikalkan removed their request for review October 17, 2023 06:28
@masum-ulu masum-ulu changed the base branch from dev to rel-7.4 October 17, 2023 06:33
@braim23 braim23 merged commit a214d0a into rel-7.4 Oct 20, 2023
1 check passed
@braim23 braim23 deleted the masum/react-native branch October 20, 2023 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants